Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GHNotificationStream "Unable to parse If-Modified-Since request header" #1984

Merged
merged 3 commits into from
Nov 21, 2024
Merged

fix GHNotificationStream "Unable to parse If-Modified-Since request header" #1984

merged 3 commits into from
Nov 21, 2024

Conversation

AsherSu
Copy link
Contributor

@AsherSu AsherSu commented Nov 12, 2024 •
edited
Loading

…-Since request header"

Description

fix GitHub notification interface return "Unable to parse If-Modified-Since request header" (fix #1985)

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (460c9fe) to head (c23e3c6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/kohsuke/github/GHNotificationStream.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1984      +/-   ##
============================================
+ Coverage     83.10%   83.11%   +0.01%     
  Complexity     2331     2331              
============================================
  Files           231      231              
  Lines          7172     7173       +1     
  Branches        378      379       +1     
============================================
+ Hits           5960     5962       +2     
+ Misses          974      973       -1     
  Partials        238      238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@bitwiseman
Copy link
Member

@AsherSu Need test that covers this branch.

@bitwiseman bitwiseman changed the title fix GitHub notification interface return "Unable to parse If-Modified… fix GHNotificationStream "Unable to parse If-Modified-Since request header" Nov 17, 2024
bitwiseman
bitwiseman requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Need to update the test to cover this path.

@AsherSu
Copy link
Contributor Author

AsherSu commented Nov 20, 2024

@bitwiseman The test cases have been reviewed and approved, are they satisfactory?

@bitwiseman bitwiseman merged commit 107c8e6 into hub4j:main Nov 21, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/notifications interface return "Unable to parse If-Modified-Since request header"
2 participants
@AsherSu @bitwiseman